On Wed, 17 Sep 2025 18:53:03 GMT, Mark Powers <[email protected]> wrote:

>> Not sure if any tests will break if we make "PBEWithHmacSHA256" the default. 
>> I'll check.
>> 
>> If the `keystore.pkcs12.macAlgorithm` security property is **not** changed, 
>> then I believe the rule is to write the keystore as it was read, meaning a 
>> keystore with the old MAC will be written as such. Removing this "PBMAC1" 
>> check would make it impossible to do this.
>
> I found one and maybe two existing tests that will have to be modified if 
> "PBEWithHmacSHA256" becomes the default.

I thought we will keep the default unchanged this time.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2360163072

Reply via email to