On Tue, 15 Jul 2025 15:03:22 GMT, Mikhail Yankelevich 
<[email protected]> wrote:

>> Replaced Thread::stop to Thread::interrupt
>
> Mikhail Yankelevich has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   breaking the loop when interrupt flag is set

Thanks for fixing this. The `terminate` method is only called once when the KDC 
has its own sub-process. In that case, since the threads are daemons there is 
really no need to interrupt them. The fix looks good but I don't know how 
effective it is if a test really needs to start a KDC, terminate it, and then 
start it on the same port.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26247#issuecomment-3319836482

Reply via email to