On Tue, 23 Sep 2025 01:18:29 GMT, Vladimir Kozlov <[email protected]> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @ashu-mehra comment - >> AOTLinkedClassBulkLoader::link_or_init_javabase_classes() should also call >> exit_on_exception() > > src/hotspot/share/cds/aotLinkedClassBulkLoader.cpp line 60: > >> 58: // Preloading requires that the Java heap objects of java.lang.Class, >> java.lang.Package and >> 59: // java.security.ProtectionDomain already exist for the preloaded >> classes. Therefore, we support preloading >> 60: // only for the classes in the static CDS archive. Classes in the >> dynamic archive are not supported because > > "for the classes in the static CDS archive"? Do you mean "AOT cache"? Or > this feature also works for old static CDS archive? I see `precond(CDSConfig::is_using_aot_linked_classes())` on following cod. Which means it only works for AOT cache. Please update comment to avoid confusion. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26375#discussion_r2370761057
