On Tue, 23 Sep 2025 01:19:59 GMT, Vladimir Kozlov <[email protected]> wrote:

>> src/hotspot/share/cds/aotLinkedClassBulkLoader.cpp line 60:
>> 
>>> 58: // Preloading requires that the Java heap objects of java.lang.Class, 
>>> java.lang.Package and
>>> 59: // java.security.ProtectionDomain already exist for the preloaded 
>>> classes. Therefore, we support preloading
>>> 60: // only for the classes in the static CDS archive. Classes in the 
>>> dynamic archive are not supported because
>> 
>> "for the classes in the static CDS archive"? Do you mean "AOT cache"?  Or 
>> this feature also works for old static CDS archive?
>
> I see `precond(CDSConfig::is_using_aot_linked_classes())` on following cod. 
> Which means it only works for AOT cache. Please update comment to avoid 
> confusion.

AOTClassLinking for the dynamic archive has been removed in 
[JDK-8367366](https://bugs.openjdk.org/browse/JDK-8367366). Currently, 
AOT-linked classes are supported for both the static archive and AOT cache. 
I've updated the comments to reflect that.

We probably should remove AOTClassLinking from static CDS archive as well. I've 
created [JDK-8368350](https://bugs.openjdk.org/browse/JDK-8368350) for that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26375#discussion_r2370946875

Reply via email to