On Tue, 16 Sep 2025 22:55:28 GMT, Mark Powers <[email protected]> wrote:
>> src/java.base/share/classes/sun/security/util/PBKDF2Parameters.java line 81: >> >>> 79: // the pseudorandom function (default is HmacSHA1) >>> 80: private ObjectIdentifier kdfAlgo_OID = >>> 81: ObjectIdentifier.of(KnownOIDs.HmacSHA1); >> >> This field is not really used? This can just be a local variable when >> parsing the DER encoding. > > It's now referenced by PBMAC1Parameters because of an earlier comment so I > can't remove it. I don't see it referenced, also it is private. I agree with Valerie that it looks like it can be a local variable inside the constructor on line 125. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2392491941
