On Mon, 6 Oct 2025 19:01:04 GMT, Sean Mullan <[email protected]> wrote:
>> src/java.base/share/classes/sun/security/util/PBKDF2Parameters.java line 89:
>>
>>> 87: private String prfAlgo = "HmacSHA1";
>>> 88:
>>> 89: public PBKDF2Parameters(DerValue keyDerivationFunc) throws
>>> IOException {
>>
>> Add some comments describing this ctor and its parameter.
>
> It's also a little unusual you are passing in the KDF algorithmId and not its
> parameters here.
fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2422387054