On Mon, 6 Oct 2025 16:53:56 GMT, Sean Mullan <[email protected]> wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more review comments from Weijun and Sean
>
> src/java.base/share/classes/sun/security/util/PBKDF2Parameters.java line 89:
>
>> 87: private String prfAlgo = "HmacSHA1";
>> 88:
>> 89: public PBKDF2Parameters(DerValue keyDerivationFunc) throws
>> IOException {
>
> Add some comments describing this ctor and its parameter.
It's also a little unusual you are passing in the KDF algorithmId and not its
parameters here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2408020713
