On Wed, 24 Sep 2025 13:24:49 GMT, Weijun Wang <[email protected]> wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix behavior with keytool
>
> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line 1493:
>
>> 1491: if (!(kdfHmac.equals("HmacSHA512") ||
>> 1492: kdfHmac.equals("HmacSHA256"))) {
>> 1493: kdfHmac = pbmac1Hmac; // use value associated with
>> keystore
>
> `pbmac1Hmac` is probably null now. If you decide to reject other algorithms
> (which I don't find necessary), error out.
Why is `pbmac1Hmac` necessary? Do we want to support writing with different PRF
and HMAC?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2376426464
