On Thu, 2 Oct 2025 18:49:53 GMT, Mark Powers <[email protected]> wrote:
>> [JDK-8343232](https://bugs.openjdk.org/browse/JDK-8343232) > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > more review comments from Weijun and Sean src/java.base/share/classes/sun/security/pkcs12/MacData.java line 364: > 362: } > 363: > 364: if (this.encoded != null) I don't think it's worth caching the `encoded` inside the object. The `getEncoded` method is only called once for each object. Just return the `encoded` output directly. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2400066890
