On Fri, 7 Nov 2025 16:06:43 GMT, Weijun Wang <[email protected]> wrote:
>> Add support for ML-DSA signing of JAR files. >> >> ~Note: https://datatracker.ietf.org/doc/draft-ietf-lamps-cms-ml-dsa/ is not >> finalized.~ >> >> Update: it is published as https://datatracker.ietf.org/doc/rfc9882/. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > a rename, a comment, and a new test case src/java.base/share/classes/sun/security/pkcs/PKCS7.java line 540: > 538: * This verifies a given SignerInfo. > 539: * > 540: * @param info the signer information. I don't believe the period is necessary. src/java.base/share/classes/sun/security/pkcs/PKCS7.java line 544: > 542: * @param cert certificate used to verify; find one inside the block > if null > 543: * > 544: * @exception NoSuchAlgorithmException on unrecognized algorithms. Shouldn't this be `@throws`? `@exception` is the old tag name. test/jdk/sun/security/tools/jarsigner/ML_DSA.java line 70: > 68: prepare(); > 69: testAPI(); > 70: testTool(); // call this last, it modified a.jar. s/modified/modifies/ ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26563#discussion_r2505007343 PR Review Comment: https://git.openjdk.org/jdk/pull/26563#discussion_r2505015654 PR Review Comment: https://git.openjdk.org/jdk/pull/26563#discussion_r2505271711
