On Fri, 7 Nov 2025 16:06:43 GMT, Weijun Wang <[email protected]> wrote:
>> Add support for ML-DSA signing of JAR files. >> >> ~Note: https://datatracker.ietf.org/doc/draft-ietf-lamps-cms-ml-dsa/ is not >> finalized.~ >> >> Update: it is published as https://datatracker.ietf.org/doc/rfc9882/. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > a rename, a comment, and a new test case One minor comment, otherwise looks good. test/jdk/sun/security/provider/pqc/ML_DSA_CMS.java line 52: > 50: // > https://github.com/lamps-wg/cms-ml-dsa/releases/tag/draft-ietf-lamps-cms-ml-dsa-07 > 51: // > https://github.com/lamps-wg/dilithium-certificates/releases/tag/draft-ietf-lamps-dilithium-certificates-13 > 52: // Although the release tags include "draft", these values are > the same as those in the final RFC 9882. and RFC 9881. ------------- Marked as reviewed by mullan (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26563#pullrequestreview-3436167538 PR Review Comment: https://git.openjdk.org/jdk/pull/26563#discussion_r2505331629
