On Tue, 2 Dec 2025 16:34:00 GMT, Alan Bateman <[email protected]> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   use Runnable() instead of CallableOp
>
> src/java.base/share/classes/java/util/jar/JarFile.java line 1043:
> 
>> 1041:             // the JAR verifier
>> 1042:             ScopedValue.where(IN_VERIFIER_INIT, true).call(
>> 1043:                     new ScopedValue.CallableOp<Void, Exception>() {
> 
> ScopedValue.Carrier defines a run method so you could use 
> `ScopedValue.where(IN_VERIFIER_INIT, true).run(..)` here and avoid the 
> exception handling.

I hadn't spotted that API, much cleaner indeed. I've updated the PR with that 
change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28609#discussion_r2582048687

Reply via email to