On Tue, 2 Dec 2025 17:05:13 GMT, Francisco Ferrari Bihurriet <[email protected]> wrote:
>> src/java.base/share/classes/java/security/Security.java line 258: >> >>> 256: } >>> 257: // We perform symlinks resolution on currentPath >>> under the >>> 258: // rationale that the original file writer is the >>> one who >> >> Nit: "the one who" is used to refer to people, while "the one that" or "the >> one which" is used for inanimate objects. > > By "file writer" I mean the person who wrote the properties file issuing a > relative `include` directive. But it is definitively confusing, how about the > following? > > // We perform symlinks resolution on currentPath > // under the rationale that the person writing the > // original properties file is the one who decided > // where the relative includes should resolve. I see, thanks for explaining. The corrected version looks good to me except I would replace `the one who decided` with `the one who decides` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24465#discussion_r2582328195
