On Mon, 19 Jan 2026 10:28:58 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> Hi! >> >> This is my proposal to transfer `KeyStore` and `KeyStoreSpi` with internal >> implementations to use `Instance`s instead of `Date`s. >> I would be very grateful for your comments and suggestions. >> >> Thanks! >> >> P.S. this is related to >> [JDK-8350953](https://bugs.openjdk.org/browse/JDK-8350953) > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > updated implementations to the latest docs src/java.base/share/classes/java/security/KeyStore.java line 1210: > 1208: /** > 1209: * Returns the instant that the entry identified > 1210: * by the given alias was created. Nit: you can fit more text on the first line before adding a line break. src/java.base/share/classes/java/security/KeyStore.java line 1215: > 1213: * > 1214: * @return the instant that the entry identified by the given alias > 1215: * was created, or {@code null} if the given alias does not exist. Nit - no period at end. src/java.base/share/classes/java/security/KeyStore.java line 1217: > 1215: * was created, or {@code null} if the given alias does not exist. > 1216: * > 1217: * @throws KeyStoreException if the keystore has not been > initialized Nit - no period at end. Remove extra spaces between @throws and KeyStoreException. src/java.base/share/classes/java/security/KeyStoreSpi.java line 133: > 131: /** > 132: * Returns the instant that the entry identified > 133: * by the given alias was created. Nit: you can fit more text on the first line before adding a line break. src/java.base/share/classes/java/security/KeyStoreSpi.java line 143: > 141: * @param alias the alias name > 142: * > 143: * @return the creation instant of this entry, or {@code null} Make wording consistent with `getCreationInstant`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29140#discussion_r2708491676 PR Review Comment: https://git.openjdk.org/jdk/pull/29140#discussion_r2708483539 PR Review Comment: https://git.openjdk.org/jdk/pull/29140#discussion_r2708487717 PR Review Comment: https://git.openjdk.org/jdk/pull/29140#discussion_r2708499409 PR Review Comment: https://git.openjdk.org/jdk/pull/29140#discussion_r2708496653
