On Wed, 28 Jan 2026 20:23:46 GMT, Bradford Wetmore <[email protected]> wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 157:
>>
>>> 155: }
>>> 156:
>>> 157: public static void severe(String msg, Object... params) {
>>
>> Since we're down here, these don't really need to be `public`.
>> Package-private is fine.
>
> I didn't see this comment (`isOn`/`severe`/`warning`/etc.) addressed? They
> are still `public`.
Just found later comment about `sun/security/util/DomainName.java`, so these
can stay public.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18764#discussion_r2738481515
