On Thu, 29 Jan 2026 18:56:55 GMT, Sean Mullan <[email protected]> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> grammar; no more 8347941 > > src/java.base/share/classes/sun/security/pkcs/NamedPKCS8Key.java line 68: > >> 66: /// >> 67: /// A `NamedPKCS8Key`, when created, must include `expanded` if >> required, its >> 68: /// `privKeyMaterial` must have already been validated for internal >> consistency. > > I don't understand this sentence - maybe should be two sentences? I can break it into 2 sentences. Basically, it means after this key has been created, the `expanded` and `privKeyMaterial` fields have already been checked for consistency so users don't need to check anymore. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24969#discussion_r2743466739
