On Sun, 1 Feb 2026 11:56:49 GMT, Jaikiran Pai <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Review feedback: improve the test to verify that certificates are returned >> - Merge branch 'master' into https_certs_8376031 >> - Review feedback >> - 8376031: HttpsURLConnection.getServerCertificates() throws >> "java.lang.IllegalStateException: connection not yet open" for the HEAD >> method > > test/jdk/sun/net/www/protocol/https/HttpsURLConnection/GetServerCertificates.java > line 151: > >> 149: .formatted(code, resp)); >> 150: >> 151: uc.getServerCertificates(); > > Here and a few other places in this test, should we assert that this returns > non-null certificates? @jaikiran I have added a check to verify that the returned certs are not null ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29489#discussion_r2760412654
