On Tue, 3 Feb 2026 12:04:50 GMT, Guanqiang Han <[email protected]> wrote:
>> Please review this change. Thanks! >> >> **Description:** >> >> VM crashes during startup on x86 when running with -XX:+UseAESCTRIntrinsics >> -XX:-UseAES. In this configuration, UseAESCTRIntrinsics may remain enabled >> while UseAES is explicitly disabled, and the VM generates AES-CTR stubs, >> hitting an assert(UseAES) in generate_counterMode_AESCrypt_Parallel(). >> >> **Fix:** >> >> Update x86 flag initialization to enforce the dependency between >> UseAESCTRIntrinsics and UseAES. When UseAES is disabled, explicitly disable >> UseAESCTRIntrinsics (with a warning when it was set on the command line), >> aligning behavior with the existing UseAES/UseAESIntrinsics gating and >> avoiding stub generation with inconsistent flag states. >> >> **Test:** >> >> GHA > > Guanqiang Han has updated the pull request incrementally with one additional > commit since the last revision: > > optimize warning log Hi @hgqxjj The fix is fine but not complete. There are more issues down in code. The main is that `FLAG_SET_DEFAULT()` is called under `!FLAG_IS_DEFAULT(UseAESCTRIntrinsics)) ` check which should be used only for `warning()` message. See lines 1162 and 1180-1192. ------------- PR Review: https://git.openjdk.org/jdk/pull/29338#pullrequestreview-3747073765
