On Tue, 24 Feb 2026 02:10:42 GMT, Anthony Scarpino <[email protected]> wrote:
>> Ben Perez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed parsing functionality in TestXDH that manually clears MSB > > test/jdk/sun/security/ec/xec/TestXDH.java line 369: > >> 367: PrivateKey privateKey = kf.generatePrivate(privateSpec); >> 368: KeySpec publicSpec = new XECPublicKeySpec(paramSpec, >> 369: Convert.hexStringToBigInteger(b_pub)); > > Can this be replaced with `new BigInteger(b_pub, 16)`? If so, the > Convert.java change isn't needed. That would work. It does seem like this is the only place `hexStringToBigInteger` is used though, so keeping that functionality might be confusing or unnecessary. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29750#discussion_r2848776210
