On Tue, 10 Mar 2026 16:51:17 GMT, Mikhail Yankelevich 
<[email protected]> wrote:

>> Hai-May Chao has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Add a negative test and restore IAE back
>
> src/java.base/share/classes/sun/security/ssl/Hybrid.java line 321:
> 
>> 319:             int expectedSecretSize = engineSecretSize();
>> 320:             if (!(from == 0 && to == expectedSecretSize)) {
>> 321:                 throw new IndexOutOfBoundsException(
> 
> ~~Do you think negative testing would be beneficial here?~~ EDIT: missed the 
> tag, sorry

Added a negative test and also removed the tag. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30167#discussion_r2921532498

Reply via email to