On Thu, 12 Mar 2026 09:01:22 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> test/jdk/sun/security/util/HexDumpEncoderTests.java line 83: >> >>> 81: result.shouldHaveExitValue(0); >>> 82: final String resultFromFile = >>> Files.readString( >>> 83: Path.of(charset.name()+".txt")); >> >> Are you sure that when a name is passed in with `-Dfile.encoding=` then the >> exact same string will be return by >> `Charset.defaultCharset().displayName()`? I really don't know about it. In >> security we have aliases and I don't know if there is something similar here. >> >> I suggest you ask review from an expert, or, if it were me I would pass the >> file name into the process. > > It returns the `FILE_ENCODING = getProperty(props, "file.encoding");` value. > Just a cleaner way of doing the same thing Rethink about it. This should be OK. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30021#discussion_r2924542638
