On Sun, 15 Mar 2026 11:33:37 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> SendaoYan has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Optimize import >> - Fix "Server not ready" error in createPKI > > test/jdk/javax/net/ssl/Stapling/HttpsUrlConnClient.java line 348: > >> 346: HttpsURLConnection tlsConn = >> 347: (HttpsURLConnection)location.openConnection(); >> 348: tlsConn.setConnectTimeout((int)Utils.adjustTimeout(5000)); > > Nit: for these timeouts, why not use the same line style as on line 635 with > specifying `SECONDS`? Sorry for the delay response. setConnectTimeout and setReadTimeout seems only recevie one arg and the time unit is millis second. So I use `TimeUnit.SECONDS.toMillis(5)` to make code more clear. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30212#discussion_r2957520661
