On Mon, 23 Mar 2026 17:37:33 GMT, Alan Bateman <[email protected]> wrote:
> Test and docs only changes:
>
> - Add test coverage for HotSpotDiagnosticMXBean.dumpThreads for the stack
> depth of owned monitors.
> - Missing comma in threadDump.schema.json, the description of the json format
> linked to in the API docs.
> - ThreadDump test library, used by the tests for
> HotSpotDiagnosticMXBean.dumpThreads, is updated with additional checks of the
> threadContainers array. Several methods are re-implemented to use streams.
> - JSONValue will likely go away once the json API is further along. In the
> mean-time, some small improvements to model boolean and null, some methods to
> better handle optional members and nulls, and change the runtime exception as
> IllegalStateException didn't make sense.
> - Update to one security test that was parsing string values as boolean.
>
> Testing: Tier 1-5.
test/lib/jdk/test/lib/threaddump/ThreadDump.java line 473:
> 471: }
> 472: if (root == null) {
> 473: throw new RuntimeException("Not root container");
Suggestion:
throw new RuntimeException("No root container");
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30379#discussion_r2976997208
