On Tue, 24 Mar 2026 14:56:14 GMT, Weijun Wang <[email protected]> wrote:
>> A new security/system property added to determine whether Java can read >> password from `System.in` if a console is not available. > > Weijun Wang has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Merge branch 'master' into 8368692 > - Merge branch 'master' into 8368692 > - merge > - more descriptive exception message > - adressing Naoto's comments; check invalid property value > - the change src/java.base/share/conf/security/java.security line 1732: > 1730: # Policy for reading passwords from System.in > 1731: # > 1732: # When Java needs to read a password, whether it's a tool such as > keytool or Wording suggestion: s/a tool/via a tool/ src/java.base/share/conf/security/java.security line 1742: > 1740: # standard input stream when a console is not available. The value can > be set > 1741: # to either "true" or "false". The default value is "true". This > default may > 1742: # change in a future release. I think it would be useful to explain what the behavior is if the property is set to false, and Java would have fallen back to `System.in` when the property was true. src/java.base/share/conf/security/java.security line 1749: > 1747: # Note: This property applies only to password reading from the > standard input > 1748: # stream. It does not affect other supported password sources. For > example, > 1749: # the JAAS KeyStoreLoginModule allows a password to be read from > users-specified s/users-specified/the user-specified/ src/java.base/share/conf/security/java.security line 1750: > 1748: # stream. It does not affect other supported password sources. For > example, > 1749: # the JAAS KeyStoreLoginModule allows a password to be read from > users-specified > 1750: # "keyStorePasswordURL". The keytool and jarsigner commands also > support options Say what type of property this is. src/java.base/share/conf/security/java.security line 1751: > 1749: # the JAAS KeyStoreLoginModule allows a password to be read from > users-specified > 1750: # "keyStorePasswordURL". The keytool and jarsigner commands also > support options > 1751: # like "-storepass:env" and "-storepass:file" to read passwords from an Do you need to say "like"? if these are the only options, just remove "like". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29490#discussion_r2990496484 PR Review Comment: https://git.openjdk.org/jdk/pull/29490#discussion_r2990509382 PR Review Comment: https://git.openjdk.org/jdk/pull/29490#discussion_r2990524111 PR Review Comment: https://git.openjdk.org/jdk/pull/29490#discussion_r2990525876 PR Review Comment: https://git.openjdk.org/jdk/pull/29490#discussion_r2990532037
