On Wed, 1 Apr 2026 21:08:59 GMT, Mark Powers <[email protected]> wrote:
> [JDK-8366979](https://bugs.openjdk.org/browse/JDK-8366979) Just a minor question src/java.base/share/classes/sun/security/pkcs12/MacData.java line 314: > 312: */ > 313: static byte[] encode(String algName, byte[] digest, PBEParameterSpec > p, > 314: String kdfHmac, String hmac, int macLength, int keyLength) Is there any point in `macLength` here, it's not used as far as I can see? Also, I don't think `throws IOException` is also needed unless I'm missing something ------------- PR Review: https://git.openjdk.org/jdk/pull/30542#pullrequestreview-4049205102 PR Review Comment: https://git.openjdk.org/jdk/pull/30542#discussion_r3026701856
