On Thu, 2 Apr 2026 08:40:00 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> comment from Mikhail > > src/java.base/share/classes/sun/security/pkcs12/MacData.java line 314: > >> 312: */ >> 313: static byte[] encode(String algName, byte[] digest, >> PBEParameterSpec p, >> 314: String kdfHmac, String hmac, int macLength, int keyLength) > > Is there any point in `macLength` here, it's not used as far as I can see? > > Also, I don't think `throws IOException` is also needed unless I'm missing > something You're right about both. Thanks for noticing this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30542#discussion_r3034720332
