On Wed, 1 Apr 2026 11:56:58 GMT, Ferenc Rakoczi <[email protected]> wrote:
> Clearing memory that might contain data from which secrets can be computed > during ML-KEM key generation, encapsulation and decapsulation as requested in > https://datatracker.ietf.org/doc/draft-sfluhrer-cfrg-ml-kem-security-considerations/ > . src/java.base/share/classes/com/sun/crypto/provider/ML_KEM.java line 2: > 1: /* > 2: * Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights > reserved. Nit: Suggestion: * Copyright (c) 2024, 2026, Oracle and/or its affiliates. All rights reserved. src/java.base/share/classes/com/sun/crypto/provider/ML_KEM.java line 664: > 662: // Note: only the 1st 32-byte in the seed is used > 663: mlKemG.update(seed, 0, 32); > 664: // mlKemG.update((byte)mlKem_k); Nit: If this is not needed, do you think this could this be removed? src/java.base/share/classes/sun/security/provider/SHA3.java line 2: > 1: /* > 2: * Copyright (c) 2016, 2025, Oracle and/or its affiliates. All rights > reserved. Nit: Suggestion: * Copyright (c) 2016, 2026, Oracle and/or its affiliates. All rights reserved. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30533#discussion_r3023484054 PR Review Comment: https://git.openjdk.org/jdk/pull/30533#discussion_r3023487320 PR Review Comment: https://git.openjdk.org/jdk/pull/30533#discussion_r3023507248
