On Wed, 1 Apr 2026 17:17:00 GMT, Mikhail Yankelevich <[email protected]> 
wrote:

>> Clearing memory that might contain data from which secrets can be computed 
>> during ML-KEM key generation, encapsulation and decapsulation as requested 
>> in 
>> https://datatracker.ietf.org/doc/draft-sfluhrer-cfrg-ml-kem-security-considerations/
>>  .
>
> src/java.base/share/classes/com/sun/crypto/provider/ML_KEM.java line 664:
> 
>> 662:         // Note: only the 1st 32-byte in the seed is used
>> 663:         mlKemG.update(seed, 0, 32);
>> 664: //        mlKemG.update((byte)mlKem_k);
> 
> Nit: If this is not needed, do you think this could this be removed?

Ooops, that line is needed, I just commented it out for an experiment and 
forgot to revert it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30533#discussion_r3023674882

Reply via email to