On Thu, 9 Apr 2026 12:07:08 GMT, Severin Gehwolf <[email protected]> wrote:

>> src/jdk.jlink/share/man/jlink.md line 245:
>> 
>>> 243: Description
>>> 244: :   Override the security properties in the `java.security` 
>>> configuration
>>> 245:     file with the properties in the specified file.
>> 
>> I think the description will need to be expanded a bit to make it very clear 
>> than the contents of the given file are used to override or add to the 
>> java.security that goes into the generated run-time image. Just trying to 
>> avoid anyone thinking it is somehow related to `-Djava.security.properties` 
>> to override the location of the file.
>
> +1. It would make sense to also document that that the `include` directive is 
> not supported.
> 
> Suggestion:
> 
>     Override the security properties - if they exist - in the 
> `conf/security/java.security`
>     configuration file with the properties in the specified file. Appends 
> properties not
>     previously present in `java.security` at the end. The `include` directive 
> is not supported.

Agree that we should be more clear to avoid confusion. Thanks for this 
suggested change. I may tweak it slightly but it looks good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30635#discussion_r3059231039

Reply via email to