On Mon, 13 Apr 2026 18:33:44 GMT, Marcono1234 <[email protected]> wrote:
>> * Improving the coverage of the `DomainKeyStore.java` >> * converting existing tests to junit in order to make logs easier to read >> * Further coverage for `DomainKeyStore.java` would be required, but should >> be done as a separate [ticket](https://bugs.openjdk.org/browse/JDK-8382096) >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > test/jdk/sun/security/provider/KeyStore/DKSTest.java line 113: > >> 111: final KeyStore ks = KeyStore.getInstance("DKS"); >> 112: ks.load(new DomainLoadStoreParameter(config, >> WRONG_PASSWORDS)); >> 113: throw new RuntimeException("Expected exception not thrown"); > > Use JUnit's `assertThrows`? For example: > > var e = assertThrows(IOException.class, ...); > ... // check e.getCause() Good idea, done in the next commit ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30712#discussion_r3078527628
