On Mon, 13 Apr 2026 15:57:45 GMT, Mikhail Yankelevich 
<[email protected]> wrote:

> * Improving the coverage of the `DomainKeyStore.java`
> * converting existing tests to junit in order to make logs easier to read
> * Further coverage for `DomainKeyStore.java` would be required, but should be 
> done as a separate [ticket](https://bugs.openjdk.org/browse/JDK-8382096)  
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

one minor comment. Otherwise, looks good to me.

test/jdk/sun/security/provider/KeyStore/DKSSystemPropertiesTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2013, 2026, Oracle and/or its affiliates. All rights 
> reserved.

this looks like a completely new file; is the copyright correct?

-------------

PR Review: https://git.openjdk.org/jdk/pull/30712#pullrequestreview-4100705171
PR Review Comment: https://git.openjdk.org/jdk/pull/30712#discussion_r3074719708

Reply via email to