On Fri, 6 Feb 2026 02:23:08 GMT, Valerie Peng <[email protected]> wrote:
> Initial commit containing the public API changes and related regression tests. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Couple minor comments src/java.base/share/classes/com/sun/crypto/provider/Argon2DerivedKey.java line 61: > 59: * Create a Argon2 derived secret key using the supplied arguments. > 60: * > 61: * @param spec the Argon2 parameters used. `type` argument is not documented. test/jdk/com/sun/crypto/provider/Argon2/TestBlake2bKAT.java line 33: > 31: * @modules java.base/com.sun.crypto.provider:+open > 32: * java.base/sun.security.provider > 33: * @summary Test the Blake2b impl with various known answer tests vectors it can be useful in the future if you document where the known answers come from or how to generate them. ------------- PR Review: https://git.openjdk.org/jdk/pull/29597#pullrequestreview-3924551101 PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r2913672853 PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r2913767025
