On Tue, 17 Mar 2026 23:02:16 GMT, Artur Barashev <[email protected]> wrote:
>> Note that this is the "max" not the default. Thus, you should not use a >> conservative value such as 64 MiB. >> Right shift 10 equals `/ 2^10`. I can add some comment for this and the >> `Long.MAX_VALUE`. >> As for the meaning of `MEMORY_MAX`, it is used to check the `memory` value. >> Note that the actual number of memory blocks can be different from `memory` >> when its value is not multiples of `4*p`. So, `MAX_MEM_BLOCKS` can be >> incorrect at times. >> Not too sure about `the limit for (t * m) value`, are you suggesting >> specifying a limit for this combination instead of `t` and `m` separately? >> Or Do you mean to use a limit for this combination instead of limiting `t`? > > - Right, `max` is what I meant actually... but as I've mentioned, having this > value in a security property would be the flexible solution. > - `MAX_MEM_BLOCKS` would mean the max number of 1 KiB blocks that can be > used, not the actual number of blocks we are using. > - The limit for `t * m` would be in addition to existing limits, limiting > just `t` by itself doesn't make much sense. > > Overall, I think we should have security properties for all those limits. I have removed the limits for now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3082758696
