On Tue, 14 Apr 2026 17:10:46 GMT, Mark Powers <[email protected]> wrote:
> [JDK-8378443](https://bugs.openjdk.org/browse/JDK-8378443) > > --------- > - [ x] I confirm that I make this contribution in accordance with the > [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). test/jdk/sun/security/provider/acvp/LMS_Test.java line 27: > 25: import sun.security.util.RawKeySpec; > 26: > 27: import java.security.*; nit: could you please change this to a non-wildcard imports if its easy to do here? test/jdk/sun/security/provider/acvp/LMS_Test.java line 60: > 58: System.out.println(">> " + pname + " verify"); > 59: > 60: for (var c : t.get("tests").elements()) { minor: could you please change this var to type if there is another revision? Just a bit hard to read this bit imo Same for line 48 test/jdk/sun/security/provider/acvp/Launcher.java line 39: > 37: /* > 38: * @test > 39: * @bug 8342442 8345057 nit: Could you please add a bug number here? test/jdk/sun/security/provider/acvp/Launcher.java line 46: > 44: * java.base/sun.security.util > 45: * java.base/com.sun.crypto.provider > 46: * @run main/othervm/timeout=480 Launcher Do you think there is a risk of this timeout being too small since the test increased in size now? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30724#discussion_r3082371619 PR Review Comment: https://git.openjdk.org/jdk/pull/30724#discussion_r3082355875 PR Review Comment: https://git.openjdk.org/jdk/pull/30724#discussion_r3082332220 PR Review Comment: https://git.openjdk.org/jdk/pull/30724#discussion_r3082340432
