On Fri, 17 Apr 2026 19:32:32 GMT, Weijun Wang <[email protected]> wrote:
>> [JDK-8378443](https://bugs.openjdk.org/browse/JDK-8378443) >> >> --------- >> - [ x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/java.base/share/classes/java/security/spec/NamedParameterSpec.java line > 125: > >> 123: * @since 27 >> 124: */ >> 125: public static final NamedParameterSpec LMS > > We cannot add a new `NamedParameterSpec` constant without a CSR. Also, > constants here are mostly used for standard parameter sets that belong to a > single family. "LMS" is itself an algorithm whose parameters are embedded > inside the key instead of as some parameters object. Removed this change. It is unnecessary. > test/jdk/sun/security/provider/acvp/LMS_Test.java line 57: > >> 55: public byte[] getEncoded() { return toByteArray( >> 56: "00000001" + t.get("publicKey").asString()); } >> 57: }; > > Why is it worth creating this key? All you need below is `pk.getEncoded()` > and you can just move the `toByteArray` call there. You're right. Done as you suggest. > test/jdk/sun/security/provider/acvp/LMS_Test.java line 58: > >> 56: "00000001" + t.get("publicKey").asString()); } >> 57: }; >> 58: System.out.println(">> " + pname + " verify"); > > Here we should print out parameters. > > System.out.println(">> " + t.get("lmsMode").asString() > + " " + t.get("lmOtsMode").asString() + " verify"); fixed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30724#discussion_r3164877348 PR Review Comment: https://git.openjdk.org/jdk/pull/30724#discussion_r3164877048 PR Review Comment: https://git.openjdk.org/jdk/pull/30724#discussion_r3164876827
