On Wed, 15 Apr 2026 08:36:58 GMT, SendaoYan <[email protected]> wrote:
> Hi all, > > Test > security/infra/java/security/cert/CertPathValidator/certification/SectigoCSRootCAs.java > fails when there is no internet connection. This PR check the outbound > network connection to > http://crl.sectigo.com/SectigoPublicCodeSigningRootR46.crl or > ocsp.sectigo.com before test executed. I think if there is no network > connection, test should not report failure, because it's not jvm bug or test > bug. It's enviroenmental issue, so maybe it's better to throw > SkippedException. > > Additional testing: > > - [x] The environmental which need proxy, and the proxy is set correctly, > test should be run passed > - [x] The environmental which need proxy, and the proxy is unset, test should > report skip > - [x] The environmental do not need proxy, test should be run passed > - [x] The environmental do not network at all, test should report skip > > > > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). test/jdk/security/infra/java/security/cert/CertPathValidator/certification/SectigoCSRootCAs.java line 29: > 27: * @summary Interoperability tests with Sectigo Public Code Signing Root > CAs > 28: * @library /test/lib > 29: * @build jtreg.SkippedException ValidatePathWithParams Skipped exception is built automatically when importing `/test/lib/` library. I don't think this change is needed, you can just have * @bug 8359170 * @summary Interoperability tests with Sectigo Public Code Signing Root CAs * @library /test/lib * @build ValidatePathWithParams What do you think? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30740#discussion_r3085752252
