> Seems there is a call to  SecIdentityCopyPrivateKey where we miss calling 
> CFRelease in early returns/failure cases; same for SecIdentityCopyPrivateKey .
> 
> See the Apple documentation
> https://developer.apple.com/documentation/security/secidentitycopyprivatekey(_:_:)
> 
> Also for 
> https://developer.apple.com/documentation/security/secidentitycopycertificate(_:_:)
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Matthias Baesken has updated the pull request incrementally with one additional 
commit since the last revision:

  Add a CFRetain after CFArrayGetValueAtIndex in addIdentitiesToKeystore

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/29821/files
  - new: https://git.openjdk.org/jdk/pull/29821/files/5d5216be..7ddde2a4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=29821&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29821&range=00-01

  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/29821.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/29821/head:pull/29821

PR: https://git.openjdk.org/jdk/pull/29821

Reply via email to