On Wed, 15 Apr 2026 15:01:50 GMT, Matthias Baesken <[email protected]> wrote:

>> Seems there is a call to  SecIdentityCopyPrivateKey where we miss calling 
>> CFRelease in early returns/failure cases; same for SecIdentityCopyPrivateKey 
>> .
>> 
>> See the Apple documentation
>> https://developer.apple.com/documentation/security/secidentitycopyprivatekey(_:_:)
>> 
>> Also for 
>> https://developer.apple.com/documentation/security/secidentitycopycertificate(_:_:)
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Add a CFRetain after CFArrayGetValueAtIndex in addIdentitiesToKeystore

Marked as reviewed by weijun (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/29821#pullrequestreview-4163329511

Reply via email to