On Wed, 15 Apr 2026 04:58:57 GMT, Valerie Peng <[email protected]> wrote:
>> Initial commit containing the public API changes and related regression >> tests. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Valerie Peng has updated the pull request incrementally with one additional > commit since the last revision: > > additional data cleanup. src/java.base/share/classes/com/sun/crypto/provider/Argon2DerivedKey.java line 108: > 106: > 107: @Override > 108: public boolean equals(Object obj) { Equals and destroy are also never triggered from what I can see. Do you think it would make sense to add a separate test covering these methods? src/java.base/share/classes/sun/security/util/Argon2Util.java line 87: > 85: builder.parallelism(parseInt(assignments[2], "p", 256)); > 86: int index = 3; > 87: while (index < assignments.length) { I don't think this while loop is tested, do you think it would make sense to make/add a test with several parameters? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3088004698 PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3087992486
