On Fri, 24 Apr 2026 16:01:51 GMT, Artur Barashev <[email protected]> wrote:
>> We need a unit test coverage for host wildcard matching as part of a TLS >> validation of the server's identity (`X509TrustManagerImpl.checkIdentity` >> call) >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Artur Barashev has updated the pull request incrementally with one additional > commit since the last revision: > > Typo fix test/jdk/javax/net/ssl/ServerName/SNIWildcardMatching.java line 60: > 58: /* > 59: * @test > 60: * @bug 8381380 Since this is a test only bug, there is no need for a bug id here. Could you please remove it? test/jdk/javax/net/ssl/ServerName/SNIWildcardMatching.java line 69: > 67: * java.base/sun.security.util > 68: * > 69: * @run main SNIWildcardMatching nit: don't thinks this is doing anything here. If you prefer to keep it I'm ok with that too test/jdk/javax/net/ssl/ServerName/SNIWildcardMatching.java line 124: > 122: > 123: for (var v : INVALID_VALUES) { > 124: runAndCheckException(() -> new SNIWildcardMatching( minor: do you think the logging of what `INVALID_VALUES` are tested at each moment would be helpful for debug in case of the failure? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30927#discussion_r3145847952 PR Review Comment: https://git.openjdk.org/jdk/pull/30927#discussion_r3145825677 PR Review Comment: https://git.openjdk.org/jdk/pull/30927#discussion_r3145821631
