On Wed, 7 Jan 2026 11:26:08 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> Passes when shouldn't in these tests: >> * test/jdk/sun/security/mscapi/IsSunMSCAPIAvailable.java >> * test/jdk/sun/security/mscapi/SignUsingSHA2withRSA.java >> * test/jdk/sun/security/mscapi/SignUsingNONEwithRSA.java >> * test/jdk/sun/security/mscapi/RSAEncryptDecrypt.java >> * test/jdk/sun/security/tools/jarsigner/CertChainUnclosed.java >> * test/jdk/sun/security/tools/keytool/StorePasswords.java >> * test/jdk/sun/security/pkcs12/StoreSecretKeyTest.java >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Mikhail Yankelevich has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into JDK-8373016 > - JDK-8373016: Passes instead of skips/ignoring the platform in > sun/security/mscapi, jarsigner, keytool and pkcs12 tests Changes requested by rhalade (Reviewer). test/jdk/sun/security/pkcs12/StoreSecretKeyTest.java line 71: > 69: // Skip test if AES is unavailable > 70: try { > 71: SecretKeyFactory.getInstance("AES"); This check does not look necessary for the test's actual behavior and will cause false skip. Test is using `KeyGenerator.getInstance` to generate keys and passed on JDK 27 without this check. test/jdk/sun/security/tools/keytool/StorePasswords.java line 161: > 159: > 160: } else if (inner2 instanceof InvalidKeyException) { > 161: throw new SkippedException(inner2.getMessage()); Maintain skip list rather than failing on first skipped algorithm. test/jdk/sun/security/util/ManifestDigester/FindSection.java line 31: > 29: import java.util.function.Consumer; > 30: > 31: import sun.security.tools.jarsigner.resources.jarsigner; Why these imports are needed? ------------- PR Review: https://git.openjdk.org/jdk/pull/28635#pullrequestreview-4191308667 PR Review Comment: https://git.openjdk.org/jdk/pull/28635#discussion_r3156299698 PR Review Comment: https://git.openjdk.org/jdk/pull/28635#discussion_r3156254250 PR Review Comment: https://git.openjdk.org/jdk/pull/28635#discussion_r3156245149
