On Tue, 28 Apr 2026 18:15:50 GMT, Rajan Halade <[email protected]> wrote:
>> Mikhail Yankelevich has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains two
>> additional commits since the last revision:
>>
>> - Merge branch 'master' into JDK-8373016
>> - JDK-8373016: Passes instead of skips/ignoring the platform in
>> sun/security/mscapi, jarsigner, keytool and pkcs12 tests
>
> test/jdk/sun/security/pkcs12/StoreSecretKeyTest.java line 71:
>
>> 69: // Skip test if AES is unavailable
>> 70: try {
>> 71: SecretKeyFactory.getInstance("AES");
>
> This check does not look necessary for the test's actual behavior and will
> cause false skip. Test is using `KeyGenerator.getInstance` to generate keys
> and passed on JDK 27 without this check.
Removed skip in the next commit
> test/jdk/sun/security/tools/keytool/StorePasswords.java line 161:
>
>> 159:
>> 160: } else if (inner2 instanceof InvalidKeyException) {
>> 161: throw new SkippedException(inner2.getMessage());
>
> Maintain skip list rather than failing on first skipped algorithm.
Actually after looking at it, I think this should stay as print since it should
not prevent the test from running even if skipped
> test/jdk/sun/security/util/ManifestDigester/FindSection.java line 31:
>
>> 29: import java.util.function.Consumer;
>> 30:
>> 31: import sun.security.tools.jarsigner.resources.jarsigner;
>
> Why these imports are needed?
No, I think this go there by accident. Removed in the next commit
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28635#discussion_r3160441527
PR Review Comment: https://git.openjdk.org/jdk/pull/28635#discussion_r3160421135
PR Review Comment: https://git.openjdk.org/jdk/pull/28635#discussion_r3160409509
