On Tue, 28 Apr 2026 12:50:12 GMT, Artur Barashev <[email protected]> wrote:

>> We need a unit test coverage for host wildcard matching as part of a TLS 
>> validation of the server's identity (`X509TrustManagerImpl.checkIdentity` 
>> call)
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Artur Barashev has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Client cert is not needed

test/jdk/javax/net/ssl/ServerName/SNIWildcardMatching.java line 95:

> 93:             {"公司.江利子.example.net", "*.example.net"}
> 94:     };
> 95: 

This new test looks good. One suggestion adding a check for multiple wildcards 
{"secret.foo.com", "s**.foo.com"}?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30927#discussion_r3166951212

Reply via email to