On Wed, 6 May 2026 00:01:29 GMT, Artur Barashev <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix variable shadowing issue in `SNIHostName` > > src/java.base/share/classes/javax/net/ssl/SNIHostName.java line 575: > >> 573: "Server name value of host_name must be a valid >> DNSName", ioe); >> 574: } >> 575: > > Nit: extra white space Removed in 3576146a8dd. > src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1: > >> 1: /* > > Update Copyright year. Fixed in 3576146a8dd. > test/jdk/javax/net/ssl/ServerName/SNIHostNamePositiveTest.java line 85: > >> 83: >> 84: // Edge cases >> 85: var edgeCases = Stream.of(new Arg<>(true, "127.0.0.1")); > > We already test this case in `SNIHostNameNegativeTest`? Not sure why we have > 2 separate tests for this change. Removed in 3576146a8dd. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30747#discussion_r3193314805 PR Review Comment: https://git.openjdk.org/jdk/pull/30747#discussion_r3193314244 PR Review Comment: https://git.openjdk.org/jdk/pull/30747#discussion_r3193315426
