On Sun, 3 May 2026 18:36:31 GMT, Volkan Yazici <[email protected]> wrote:
>> Per [RFC 6066 "3. Server Name Indication"], disallow IP literals in >> `SNIHostName::new`. >> >> While the following two call-sites could be simplified by removing IP >> literal checks, I've refrained from doing so because delegating some of the >> checks to an exception catching mechanism would impact the performance: >> >> sun.security.ssl.Utilities::rawToSNIHostName >> sun.net.www.protocol.https.HttpsClient::afterConnect >> >> [RFC 6066 "3. Server Name Indication"]: >> https://www.rfc-editor.org/rfc/rfc6066.html#page-6 >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision: > > Fix variable shadowing issue in `SNIHostName` test/jdk/javax/net/ssl/ServerName/SNIHostNamePositiveTest.java line 85: > 83: > 84: // Edge cases > 85: var edgeCases = Stream.of(new Arg<>(true, "127.0.0.1")); We already test this case in `SNIHostNameNegativeTest`? Not sure why we have 2 separate tests for this change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30747#discussion_r3191667303
