On Thu, 7 May 2026 10:59:58 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added tests > > test/jdk/sun/security/tools/keytool/CloseFile.java line 31: > >> 29: * @modules java.base/sun.security.tools.keytool >> 30: * @compile -XDignore.symbol.file CloseFile.java >> 31: * @run main CloseFile > > Should this be removed? Why not leave both in? Then it would be clear that > the issue is related to one of the mac algorithms below and would test > default value in case it's different > > Same for the other tests. > > What do you think? Good idea. I hadn't considered testing the default value. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31031#discussion_r3202996766
