On Tue, 19 May 2026 05:50:47 GMT, Ashay Rane <[email protected]> wrote:
>> The powershell binary is required to run these tests but in the GitHub >> workflow that runs tests (specifically, in test.yml), we reset the PATH >> environment variable on Windows, causing the GitHub workflow to fail if >> you run these tests. The tests pass locally since local test runs don't >> modify PATH. >> >> To make these tests pass in GitHub workflows, this patch updates the >> tests to refer to PowerShell using the canonical path on Windows. See >> https://github.com/raneashay/openjdk-jdk/actions/runs/25680763981/job/75401590988 >> for a sample workflow run of the tier2 part1 tests, which include the >> CngCipher and DupAlias tests. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ashay Rane has updated the pull request incrementally with one additional > commit since the last revision: > > Address PR comments > > 1. Replaced `PowerShellPath()` with `powerShellPath()` to maintain > consistency with the rest of the functions in FileUtils.java. > > 2. Updated copyright year to 2026. Marked as reviewed by myankelevich (Committer). Yes, I see your point. It's even worse since it's mostly used in other helpers too. I'd leave it as is then. Thanks for your changes ------------- PR Review: https://git.openjdk.org/jdk/pull/31127#pullrequestreview-4326478711 PR Comment: https://git.openjdk.org/jdk/pull/31127#issuecomment-4496102694
