On Wed, 27 May 2026 11:29:05 GMT, Maurizio Cimadamore <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2732 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - 8385344: [lworld] ProblemList >> tools/javac/platform/CanHandleClassFilesTest.java with --enable-preview >> >> Reviewed-by: fparain >> - 8385301: [lworld] Remove >> serviceability/sa/TestJhsdbJstackMixedWithXComp.java from problem list >> >> Reviewed-by: dsimms >> - 8385331: [lworld] adjust ValueComparisonTest.java again to work around >> JDK-8370769 >> >> Reviewed-by: dsimms >> - 8385311: [lworld] TypePtr::eq() should use accessor method for _offset >> >> Reviewed-by: mchevalier >> - 8385259: [lworld] Clean up LP64 in x86 code >> >> Reviewed-by: dlong, thartmann >> - Merge >> >> Merge jdk-27+23 >> - 8384924: [lworld] misc cleanups >> >> Reviewed-by: thartmann >> - 8385167: [lworld] C1: minor cleanups >> >> Reviewed-by: dlong, thartmann >> - 8384066: [lworld] TestDeadAllocationRemoval.java is ignored by jtreg >> >> Reviewed-by: thartmann >> - ... and 2722 more: https://git.openjdk.org/jdk/compare/86637704...b3b4a2cb > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 680: > >> 678: } >> 679: >> 680: void checkConstraintsOfValueClass(JCClassDecl tree, ClassSymbol c) { > > Maybe just "checkValueClass" is enough here Also, not sure this method is needed. It seems to be doing two things: * check whether the value class has any non-value superclass * check whether the value class has any synchronized method (or any of its super has) For the former, just a simple check on the direct superclass should be ok -- after all, the only superclass allowed there is another "abstract value", so correctness of that class will have been verified independently. And the latter is already verified by Check anyway. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31120#discussion_r3310615717
