On Wed, 3 Jun 2026 19:12:40 GMT, Chen Liang <[email protected]> wrote:

>> test/lib/jdk/test/lib/net/HttpHeaderParser.java line 92:
>> 
>>> 90:     public HttpHeaderParser(InputStream is) throws IOException, 
>>> ProtocolException {
>>> 91:         parse(is);
>>> 92:     }
>> 
>> Would the correct way of getting rid of this 
>> `@SuppressWarnings("initialization")` annotation here be to change the 
>> constructor to either call `this();` or `super();` before `parse(is);`?
>> 
>> I am not saying that it should happen in this PR but I would like to 
>> understand what kind of followup work might be needed in the networking 
>> area. Thanks!
>
> In this particular case, I think the equivalent is to add `super();` before 
> `parse(is)`, which is an instance call not allowed in prologue when all 
> implicit `super()` calls are injected to the end of constructor bodies 
> instead. But using `this()` is  probably a better way to convey intentions.

Thank you!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3361721454

Reply via email to