On Fri, 5 Jun 2026 16:46:01 GMT, Sean Mullan <[email protected]> wrote:

>> This change adds the negotiated named group to the JFR TLSHandshakeEvent.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Sean Mullan has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Switch order of fields.

test/jdk/jdk/jfr/event/security/TestTLSHandshakeEvent.java line 58:

> 56:                       "ffdhe2048", 3188175476l),
> 57:         new TLSConfig("TLSv1.2", "TLS_RSA_WITH_AES_256_CBC_SHA",
> 58:                       "N/A", 3010289526l)

Suggestion:

                      3237675498l),
        new TLSConfig("TLSv1.3", "TLS_CHACHA20_POLY1305_SHA256",
                      "X25519MLKEM768", 3237675498L),
        new TLSConfig("TLSv1.2", "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384",
                      "secp256r1", 3237675498L),
        new TLSConfig("TLSv1.2", "TLS_DHE_DSS_WITH_AES_256_GCM_SHA384",
                      "ffdhe2048", 3188175476L),
        new TLSConfig("TLSv1.2", "TLS_RSA_WITH_AES_256_CBC_SHA",
                      "N/A", 3010289526L)

Let's use `L` to not confuse with `1`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31371#discussion_r3378923435

Reply via email to